Skip to content

docs(tools): guía actualizada de upscale, Revoice y quitar fondo - #225

Open
cursor[bot] wants to merge 3 commits into
developmentfrom
cursor/engineering-documentation-updates-46a6
Open

docs(tools): guía actualizada de upscale, Revoice y quitar fondo#225
cursor[bot] wants to merge 3 commits into
developmentfrom
cursor/engineering-documentation-updates-46a6

Conversation

@cursor

@cursor cursor Bot commented Sep 7, 2026

Copy link
Copy Markdown

Resumen ejecutivo

Qué cambia

Añade una guía de Studio Tools y actualiza sus enlaces y documentación de API sobre la base actual de development.

Para qué sirve

Aclara qué camino usa cada operación: upscale por el comando compartido V2 desde Studio/Wizard/MCP; Revoice y quitar fondo por sus rutas nativas. Corrige afirmaciones obsoletas sobre Revoice en Wizard, referencias, métodos y selección de recursos.

Impacto para el usuario

Los ejemplos usan el contrato vigente. Se explica cómo conservar carpeta fuente, recibo e intención de una petición, y que las instrucciones de rembg son metadatos: no dirigen la máscara.

Riesgo

  • Bajo: solo documentación.

Estado

  • Listo para revisión
  • CI obligatoria del HEAD actualizado aprobada

Summary

Refresh the proposed Tools operator guide against development, including shared tools.upscale V2 and its receipt/replay behavior. Keep the native legacy schemas distinct. Remove unrelated music and local-validation changes from this PR's final scope.

Overview

Choose an existing source in Studio Tools, select the operation and parameters, then follow the returned job. The source remains intact and results belong to the destination output folder. The guide distinguishes that folder from a logical Workspace collection and preserves the source URL scope.

Detailed changes

Backend

No runtime changes. API documentation distinguishes the version 2 command envelope from flat native Tools requests, explains rembg's accepted formats and metadata-only instruction, and describes Revoice's one/two-reference behavior.

UI and Wizard

Document the current resource picker and processor discovery. Wizard has upscale and remove-background adapters; it does not expose a dedicated Revoice action. Do not infer shared support for all Tools from the existence of tools.upscale.

Data, provenance and compatibility

The shared upscale example requires a canonical resource or exact asset ID, explicit method/kind/output workspace and stable intent_id for response recovery. Native paths retain their existing separate contract. No persistence, model, launcher or runtime changes.

Files and ownership

  • docs/tools/HOWUSEIT.md: operator guide and examples.
  • app/docs/API.md: current HTTP contracts and shared-command links.
  • README.md, docs/HOWUSEIT.md, Character Kits and Video Editor guides: Tools links only.

Validation

  • Base: 73ec9091badd6e3e90c7bba70d5114a816c29ecc (development).
  • Head: 978b7a92e46aacba79a1ff0d3627836c8293b564.
  • Clean-repo guard and existing documentation contract check: PASS.
  • All 35 local link targets across the six changed Markdown files exist; anchor contents were not validated.
  • All three curl request examples parse as JSON. The shared upscale example passes the actual specification freezer with exact preservation of original; the rembg example passes its actual request schema. Revoice JSON shape inspected against its native handler.
  • git diff --check: PASS. No product or tests delta against development.
  • No API mutation, model inference, local full UI rerun or new media generation for this documentation-only change.

CI and review

  • Updated from the old main-based proposal to current development; pushed without force.
  • CI on this HEAD: SUCCESS, run 34410838191. 3,022 Python passed / 9 skipped; 1,444 UI passed; 26 Chromium E2E and 5 Windows Speech export E2E passed. CI required SUCCESS. Both Cursor automations completed successfully; formal Independent QA remains NEUTRAL.
  • Source/contract review performed here; independent Luna review unavailable because workers exhausted their quota.
  • No remote merge or publication to main.

Notes and limitations

This guide documents implemented behavior, not a new shared Revoice/rembg operation or a quality guarantee for every processor. Example resources must exist before executing the commands. The standalone link check verifies local file targets, not every fragment or external website.

Document the post-processing Tools panel (upscale, SeedVC revoice, rembg)
against the current HTTP and worker contracts, including the unused
instruction field and narrower rembg formats. Cross-link the HOWUSEIT
index, README, API, and related guides; note local Music3 vs remote
MiniMax and persist-before-generate song identity; record validate_local
PATH inheritance and fail-closed UI steps.

Co-authored-by: ignaciodelcano+dcl <ignaciodelcano+dcl@gmail.com>
@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

PR Review — Loreframe Studio

Risk: low
Scope: 6 file(s); +270/-16; docs

Automated review from scripts/analyze_pr.py. This is a heuristic pass (no LLM) so humans still own the merge decision.

Findings

  • No heuristic issues. Still run the CI checklist below.

Changed files

  • added: docs/tools/HOWUSEIT.md
  • modified: README.md, app/docs/API.md, docs/HOWUSEIT.md, docs/character-kits/HOWUSEIT.md, docs/video-editor/HOWUSEIT.md

CONTRIBUTING checklist

  • python scripts/verify_clean_repo.py
  • python -m compileall -q app/services app/launch.py scripts
  • cd ui && npm run build if the UI changed
  • No weights, CivitAI sidecars, or generated guides
  • Stays local-first (no required accounts / telemetry)

Posted by the repo PR review workflow. Re-runs on each push to the PR.

@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

Code health

Quality score: 58.7/100

Higher is better. The score is a trend dashboard; the independent ratchet below remains the CI gate.

Component Weight Current Change
Cyclomatic health 45% 56.2 +0.0
File concentration 25% 66.4 +0.0
Oversized-file debt 20% 42.4 +0.0
Modularity 10% 83.0 +0.0

Change vs PR base: +0.0 points.

Metric Value
Production LOC 282,856
Production files 856
Test LOC 111,739
Functions measured 18,647
Functions complexity ≥ 15 865
Maximum complexity 674
Policy code-health-policy-v1
HEAD f8360858049e06539728df19d0c614311464a224
Base 73ec9091badd6e3e90c7bba70d5114a816c29ecc
UI measurement complete

Markdown, JSON catalogs and tests are out of this table. Only app/ runtime + ui/src TS/JS count.

Most complex functions

Complexity Where
674 app/wgp.py:7221 generate_video
379 ui/src/stores/useStore.ts:4122 Async method 'startGeneration'
355 app/_launch_runtime.py:23653 _run_generation
308 app/wgp.py:12363 generate_video_tab
264 ui/src/stores/useStore.ts:8667 Async method 'loadSettingsFromOutput'
262 ui/src/components/Sidebar/SceneAnimatorPanel.tsx:496 Function 'SceneAnimatorPanel'
258 app/services/director/planners/short_film.py:3433 ShortFilmPlanner._plan_story_driven
248 app/services/director_pipeline.py:13607 _run_video_generation
245 app/services/director_pipeline.py:7712 _run_pipeline
233 ui/src/features/agent/agentActions.ts:1152 Function 'parseAction'
226 app/services/director_pipeline.py:6541 update_comic_preview
225 ui/src/features/agent/agentActions.ts:2937 Async function 'executeAgentActions'

Trend vs baseline

Metric Δ
Production LOC +0
Test LOC +0
Functions ≥ 15 +0
Maximum complexity +0

Ratchet passed.

@IAnMove

IAnMove commented Sep 8, 2026

Copy link
Copy Markdown
Owner

Revisión independiente: sigue en draft. No retarget ni ready.

La guía de Tools y la corrección de instruction en rembg sí aportan, pero el PR enseña contratos que el código no cumple, en main y en development:

  • Wizard no envía upscale/revoice; toolsAdapter solo hace rembg.
  • ?workspace= vs source_workspace no es 409; gana el campo tipado (200 en tests).
  • Videoclip Music3 en Story Lab es 20–300 s, no 5–300.

Además, frente a development ya está desfasada: picker AssetInput sin ?kind=image, y HTTP upscale incluye rife/dlssg/dlss5/h3facerefine.

Hay que reescribir esas afirmaciones (y mejor contra development) antes de sacarlo de draft.

@IAnMove IAnMove changed the title docs: guía de Studio Tools y huecos de la semana docs(tools): guía actualizada de upscale, Revoice y quitar fondo Sep 9, 2026
@IAnMove
IAnMove changed the base branch from main to development September 9, 2026 22:10
@IAnMove
IAnMove marked this pull request as ready for review September 9, 2026 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants